Improved Error Handling, Performance Profiler #734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added overridable `_handle_return_code` method - Handled loop over integrate return code in hybrid solver
- Added `Logger` with virtual methods, allows overriding (e.g. out to file) - Initial stderr logger added
This is so that profilers/debuggers/etc. can use the same Makefile. - Ability to include definitions with `build_simulation()` - Updates to profiler code
Use `test/profiling/profiler.py` to run basic performance profiling. - Removed relative imports in profiler files - Added CLI args to script
jtcooper10
changed the title
BryanRumsey
approved these changes
Mar 29, 2022
briandrawert
approved these changes
Mar 30, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates C++ solvers to return an enumerated status on error (rather than always returning 0), which then is mapped to an exception Python-side and handled. Raised as a
SimulationError, which can then be caught.In addition, the code contained in the
test/profilingdirectory was updated for use in C++ profiling. While the profiler is not fully feature-complete (that may be addressed in another PR), it was made functional enough to use in comparing error handling implementations in theSSACSolver.Also fixes failing tests that were silently ignored due to exceptions not being raised properly.
Changes
Loggerclass to C++ solversTauHybridCSolverto bubble up exception on "loop over integrate"test/profilingFixes
--verbose) caused seg fault