Integrator options support + validation #786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added class methods for getting/validating integrator options - Updated `TauHybridCSolver` to use it
- Move `--atol`, `--reltol`, and `--max_step` results into separate struct - Update ODE and Hybrid C++ solvers to use this struct
- Added `--max_step` support to `ODECSolver` - Added `configure()` method to `TauHybridCSolver`'s integrator
Merged
Member
|
Please add unit test to see that an warning is not raised when --rtol, etc are passed to the solver object. |
BryanRumsey
requested changes
May 25, 2022
Contributor
BryanRumsey
left a comment
BryanRumsey
left a comment
There was a problem hiding this comment.
Integrator options were not added to ODECSolver.run
Collaborator
Author
Added along with a unit test. |
Collaborator
Author
A unit test was added. |
BryanRumsey
approved these changes
Jun 1, 2022
briandrawert
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements support for CVODE integrator options in C++ solvers, as well as implementing a more extensible approach for validating and modifying supported integrator options for each solver.
Each solver may "declare" which integrator options they support by overriding the
GillesPySolver.get_supported_integrator_optionsclass method and returning a set of supported options.Changes
TauHybridCSolver#runandODECSolver#runnow supportintegrator_optionsas an argumentrtol,atol, andmax_stepas optionsFixes
Closes #730