Skip to content

Fix hybrid switching #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BryanRumsey merged 21 commits into from
Aug 9, 2022
Merged

Fix hybrid switching #853

BryanRumsey merged 21 commits into from
Aug 9, 2022

Conversation

@briandrawert
Copy link
Member

@briandrawert briandrawert commented Jul 26, 2022

No description provided.

@briandrawert
Changed how CV is calculated, now using time-averaged. Corrected CV c…
8900ef3 
…alculation, now using sqrt. Changed default CV tol=0.005
@briandrawert
clean up
6b5e59f
@briandrawert briandrawert self-assigned this Jul 26, 2022
@briandrawert briandrawert added the bug Something isn't working label Jul 26, 2022
@briandrawert briandrawert added this to the 1.7.0 milestone Jul 26, 2022
@briandrawert briandrawert linked an issue Jul 26, 2022 that may be closed by this pull request
Hybrid switching sensitivity may have been lost #849
Closed
@briandrawert briandrawert modified the milestones: 1.7.0, 1.6.10 Jul 26, 2022
@briandrawert briandrawert marked this pull request as draft July 26, 2022 17:46
briandrawert and others added 12 commits July 26, 2022 11:44
@briandrawert
Fixing the tau step size selection code, needed reactants and product…
91a6105 
…s for reactions of the type A+B->B+C, which have a net stoich of zero
@briandrawert
Using time-averaged CV for TauHybridCSolver, and swtich_tol is now pa…
8637d1e 
…ssed correctly to solver
@briandrawert
for switch_tol=0.005, the C and python solvers differ
59e0c61
@briandrawert
removing the tau step size from hybrid switching calculation
9b5c135
@briandrawert
going back to CV_a
2db2140
@briandrawert
Merge branch 'develop' of github.com:StochSS/GillesPy2 into no_tau_in…
0daa2d1 
…_switching_calc
@briandrawert
Fixed bugs in Tau-Hybrid solvers
1d18841
@briandrawert
recucing test runtimr
f73678c
@briandrawert
checking tests
7467d5e
@briandrawert
fixed bug in dependency graph
90c8f72
@briandrawert
re-enabling all integration tests
c94ccdc
@briandrawert
Merge pull request #854 from StochSS/no_tau_in_switching_calc
c7360b1 
Removing tau step size from hybrid  switching calc
@briandrawert briandrawert marked this pull request as ready for review August 1, 2022 21:03
briandrawert
briandrawert commented Aug 3, 2022
View reviewed changes
briandrawert
briandrawert commented Aug 3, 2022
View reviewed changes
briandrawert
briandrawert commented Aug 3, 2022
View reviewed changes
@BryanRumsey BryanRumsey merged commit 076fa18 into develop Aug 9, 2022
@BryanRumsey BryanRumsey deleted the fix_hybrid_switching branch August 9, 2022 18:26
@BryanRumsey BryanRumsey mentioned this pull request Aug 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanebum seanebum seanebum approved these changes

@BryanRumsey BryanRumsey BryanRumsey approved these changes

@jtcooper10 jtcooper10 Awaiting requested review from jtcooper10

@kevinsanft kevinsanft Awaiting requested review from kevinsanft

Assignees

@briandrawert briandrawert

Labels

bug Something isn't working

Projects

None yet

Milestone

1.7.0

Development

Successfully merging this pull request may close these issues.

Hybrid switching sensitivity may have been lost

4 participants

@briandrawert @seanebum @BryanRumsey