Skip to content

Clarify dependencies #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
briandrawert merged 4 commits into from
Oct 26, 2022
Merged

Clarify dependencies #881

briandrawert merged 4 commits into from
Oct 26, 2022

Conversation

@BryanRumsey
Copy link
Contributor

@BryanRumsey BryanRumsey commented Oct 11, 2022

Changes

  • Added NumPy to requirements.
  • Removed NumPy import checks.
  • Removed un-necessary NumPy checks and confusing error message.

closes #880

@BryanRumsey BryanRumsey added the enhancement New feature or request label Oct 11, 2022
@BryanRumsey BryanRumsey added this to the 1.7.2 Release milestone Oct 11, 2022
@BryanRumsey BryanRumsey self-assigned this Oct 11, 2022
@BryanRumsey BryanRumsey mentioned this pull request Oct 11, 2022
Merged
@briandrawert briandrawert merged commit 6aae482 into develop Oct 26, 2022
@briandrawert briandrawert deleted the clerify-dependenciea branch October 26, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@briandrawert briandrawert briandrawert approved these changes

@seanebum seanebum seanebum approved these changes

Assignees

@BryanRumsey BryanRumsey

Labels

enhancement New feature or request

Projects

None yet

Milestone

1.7.2 Release

Development

Successfully merging this pull request may close these issues.

4 participants

@BryanRumsey @briandrawert @seanebum