Skip to content

Conversation

@zgpky
Copy link
Contributor

@zgpky zgpky commented Sep 16, 2025

  • Flattened PolylineArrowMaterial, PolylineDashMaterial, PolylineOutlineMaterial, and PolylineGlowMaterial
  • Removed redundant nesting of material properties
  • Restricted Polyline.material and Polyline.depthFailMaterial to accept only PolylineMaterial, str, or TimeIntervalCollection
  • Updated tests accordingly

@codecov
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.80%. Comparing base (d34662e) to head (a7795c4).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
- Coverage   99.80%   99.80%   -0.01%     
==========================================
  Files           9        9              
  Lines        1564     1550      -14     
==========================================
- Hits         1561     1547      -14     
  Misses          3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Stoops-ML
Copy link
Owner

Thank you so much! Great work!

Looks like you need to apply ruff format and ruff check —fix to pass the quality test. Then you’re all good!

@zgpky
Copy link
Contributor Author

zgpky commented Sep 16, 2025

I’ve applied ruff format and ruff check --fix as suggested.

@Stoops-ML Stoops-ML merged commit 317d918 into Stoops-ML:main Sep 17, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants