Remove dummy currencies

[zimme]

How about removing XXX and XTS as they seem to be there for "testing" or as dummy currencies.

[steffanhalv]

It's still ISO standard https://en.wikipedia.org/wiki/ISO_4217

I think we keep it, but If you need it you could create a new function which excludes test currencies, or add a param to coinify.get which excludes them

You are welcome to contribute :)

[zimme]

Aaah, standards.... 😜

Well... for my usecase I just copied the currency map into my app and fixed some of the things I needed.

I basically needed [{ code: ..., name: ...}, ....] to give my users the ability to choose any currency in a "nice" way.

[steffanhalv]

I see.

I think I keep this open as it could be useful in several cases. Will take a look at it later ;)

[chikamichi]

Hi,

I wouldn't be surprised most coinify users are interested in "active national currencies". It might then make sense shipping with a default list that excludes X** entries. A user would then opt-in arbitrary X** entries, either currency-per-currency (XAU, XTS…), or through categories (metals, testing, supranationals…).

That's a breaking change if it overrides the default export of course, but one could always provide an additional export. API is unclear yet, but speaking of exports, why not providing all those extra currencies as named exports and adding a merge-type operator?

import coinify, { metals } from 'coinify'

// coinify doesn't expose X** currencies by default, but…
// user can either:
coinify.merge(metals).get('XAU')
// or:
metals.get('XAU')

[steffanhalv]

Interesting Idea as it will keep the import size minimal in contrast to adding a new param 'usecase' ...

If we increase version to 3.0.0 it should not have big effect on most dependents as npm install is usually locked on 2.x.x I think

[chikamichi]

I believe it is locked indeed since package.json uses carret ranges by default, which preserves the left-most (MAJOR in this case) version number.