Audit hardening: rate-limiter bound, logout cookie path, Cloudflare Tunnel docs#40
Merged
Conversation
…el setup - Bound the in-memory login-attempt map (sweep expired entries past 10k IPs) so a wide scan can't grow it forever now that internet exposure via a tunnel is a documented deployment. - Clear the session cookie with the same path it was set with, so logout works when the app is served under BASE_PATH. - Fix the stale urlguard.js header: the strict SSRF guards are kept but unused; the active policy (LAN targets allowed, admin-only) matches SECURITY.md. - README/SECURITY.md: Cloudflare Tunnel guidance (Cloudflare Access in front, TRUST_PROXY=1, https BASE_URL) and a README typo fix. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups from a v1 security + project-setup audit.
App fixes
pathit was set with, so logout works onBASE_PATH(subpath) deployments.Docs
TRUST_PROXY=1and an httpsBASE_URL.All 111 server tests pass; client builds clean.
🤖 Generated with Claude Code