Skip to content

fix: skip framework download when already at latest version#5

Merged
montfort merged 1 commit intomainfrom
fix/framework-update-skip-current
Mar 19, 2026
Merged

fix: skip framework download when already at latest version#5
montfort merged 1 commit intomainfrom
fix/framework-update-skip-current

Conversation

@montfort
Copy link
Contributor

Summary

  • Add semver version comparison in update-framework before downloading, matching the pattern already used by update-cli in self_update.rs
  • Without this fix, every devtrail update re-downloads and overwrites all 65 framework files even when the installed version matches the latest release

Test plan

  • cargo build — compiles clean
  • cargo test — 25 tests passing
  • Verified version comparison chain: checksums.version ("fw-2.1.0") → strip_tag_prefix ("2.1.0") → semver parse → correct comparison

🤖 Generated with Claude Code

Add semver comparison in update-framework to match the pattern already
used by update-cli in self_update.rs. Without this, every `devtrail
update` re-downloads and overwrites all 65 framework files even when
the installed version matches the latest release.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@montfort montfort merged commit 0f638c3 into main Mar 19, 2026
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants