Conversation
…#67) Canonizes the human-approval signal for documents whose `review_required: true` previously had no closure mechanism. Implementation of issue #67 (RFC: Canonical approval workflow), validated empirically in Sentinel where the same shape was applied locally to 2 AIDECs as "Opción B". Adds 3 optional frontmatter fields to all 11 templates that need formal approval (AIDEC, ETH, MCARD, ADR, DPIA, INC, SEC + 4 China variants: PIPIA, CACFILE, TC260RA, AILABEL) across EN, ES, and zh-CN — 33 template files total: reviewed_by: <reviewer-id> # email | github-handle | DID reviewed_at: YYYY-MM-DD review_outcome: approved | revisions_requested | rejected Fields ship as commented YAML so existing documents continue to validate. The presence of `review_outcome` is the canonical "human has reviewed" signal; `review_required: true` remains as historical record after approval (it's not toggled to false). DOCUMENTATION-POLICY.md (3 langs) gets: - §2 Optional Fields extended with the 3 new fields. - New §3.5 "Recording Approval" section explaining closure semantics, the canonical body section format (compatible with existing ## Approval tables in 7 templates), the multi-reviewer convention for v1 (chronological body blocks; structured array deferred), and the CLI tooling on the way (`devtrail approve`, `devtrail validate --check-pending-reviews` in PRs 5-6). This PR is templates + docs only — no code. The CLI commands that populate these fields atomically land in PRs 5 and 6. 356/356 tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Closes #67
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fourth of 8 PRs implementing Phase 2. Canonizes the human-approval signal that issue #67 identified as a gap. Validated empirically in Sentinel (2 AIDECs applied the same shape locally as "Opción B" before this canonization).
What's added
3 optional frontmatter fields in all 11 templates that need formal approval (AIDEC, ETH, MCARD, ADR, DPIA, INC, SEC + China: PIPIA, CACFILE, TC260RA, AILABEL) across EN, ES, and zh-CN — 33 template files total:
Ship as commented YAML so existing documents continue to validate without modification.
Semantics:
review_outcomeis the canonical "human has reviewed" signal.review_required: trueis NOT toggled tofalseafter approval — it remains as historical record of why review was needed.reviewed_atmust be>= created(will be enforced bydevtrail validatein PR 6).DOCUMENTATION-POLICY.md(EN + ES + zh-CN):## Approvaltables in 7 templates), multi-reviewer convention for v1 (chronological body blocks; structured array deferred), and the CLI tooling on the way.What's NOT in this PR
devtrail approvecommand lands in PR 5, anddevtrail validate --check-pending-reviewsin PR 6.## Approvaltable sections (ETH, MCARD, SEC, PIPIA, CACFILE, TC260RA, AILABEL) keep their tables — both forms are documented as canonical, with the frontmatter fields as the machine-readable source of truth.review:array form — explicitly deferred until at least one adopter exercises a real multi-reviewer flow.Test plan
Closes #67.
🤖 Generated with Claude Code