fix(cli): skip prompts TTY test when stdin is a TTY#174
Merged
Conversation
The require_interactive_errors_in_non_tty test asserted that require_interactive() fails when stdin is not a TTY, relying on the assumption that `cargo test` always runs without a TTY. That assumption breaks when running `cargo test` from an interactive shell, where stdin is inherited and the assertion fails. Add a runtime guard at the top of the test: if stdin is a TTY, return early. Under CI or piped invocations the test still exercises the real non-TTY path. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
require_interactive_errors_in_non_tty(cli/src/prompts.rs) failed whencargo testran from an interactive shell because stdin was inherited as a TTY, contradicting the test's assumption.Test plan
cargo test --bin straymark→ 320 passed, 0 failed (TTY path: early return)cargo test --bin straymark < /dev/null→ 320 passed, 0 failed (non-TTY path: assertion exercised)🤖 Generated with Claude Code