fix(cli): charter new "Next steps" output renumbers when origin set (cli-3.6.1)#69
Merged
Merged
Conversation
…cli-3.6.1) `devtrail charter new` output skipped from step 2 to step 4 when --from-ailog or --from-spec was passed. The conditional origin-step (step 3 in the no-origin path) was suppressed correctly, but the remaining steps had hardcoded numbers that did not re-sequence. Reported as F1 of AILOG-2026-05-02-028 in Sentinel during the first end-to-end execution of CHARTER-01 (format v4 atomic Charter closure pattern). Fix: extract the step list into a pure function next_steps that builds steps as data and applies dynamic numbering via enumerate(). Four unit tests verify behavior across the three origin paths (no flag, --from-ailog, --from-spec) and guard against regression to the hardcoded form. Editorial/cosmetic fix. No schema changes. No behavior change beyond the printed output. cli-3.6.0 Charters are unaffected. First CLI patch driven directly by an empirical Charter-execution finding. Validates the disposition rule from CHARTER-01 of Sentinel: bug-class frictions with obvious fix paths flow upstream as patches without ceremony, while observation-class frictions accumulate in the AILOG until 3+ patterns emerge. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
devtrail charter newoutput skipped from step2.to step4.when--from-ailogor--from-specwas passed. Hardcoded numbering didn't re-sequence after the conditional origin-step was suppressed.next_steps(from_ailog, from_spec) -> Vec<String>and apply dynamic numbering viaenumerate(). Four unit tests cover the three origin paths and guard against regression.Sentinel AILOG-2026-05-02-028during the first end-to-end execution ofCHARTER-01(format v4 atomic Charter closure pattern).Test plan
release-cli.ymlbuilds 4 platforms on tag push.devtrail charter new --type S --title "test" --from-ailog AILOG-2026-04-28-021(in any repo with a matching AILOG) shows steps numbered1. 2. 3.(not1. 2. 4.).cargo test: 4 new unit tests + existing 209 unchanged.Post-merge
🤖 Generated with Claude Code