fix: O3 — charter drift --no-ailog-suppress always emits INFO line (cli-3.8.1 + fw-4.7.1)#92
Merged
Merged
Conversation
…O line Closes the last pending design discussion from issue #81 (option (c) per Sentinel CHARTER-06 telemetry on issue #91). Resolution: --no-ailog-suppress now always emits at least one line at end of output, regardless of N. Default mode is unchanged. Default + N=0: silent (no new noise — the common case) Default + N>0: AILOG-suppressed: N path(s) block (existing behavior) --flag + N=0: INFO: AILOG-aware suppression bypassed (would have suppressed: 0 paths) --flag + N>0: INFO: AILOG-aware suppression bypassed (would have suppressed: N path(s) listed above) + per-path list with documenting AILOG ID Implementation: compute_ailog_suppressions now runs unconditionally so the count is available regardless of whether suppression is applied. The flag controls only whether suppression mutates the rendered drift list. The asymmetry matches `git diff --stat` — silent default, signal on explicit opt-in. Operators with dispatch suspicion have a one-flag debug path that always says something. Tests: 3 new integration tests (N=0 with flag emits INFO; N>0 with flag emits INFO + per-path list; default at N=0 stays silent — negative test that we didn't add noise). 414/414 pass. Bumps cli-3.8.1 / fw-4.7.1 across canonical surface (governance footers, README + CLI-REFERENCE versioning tables, ADOPTION-GUIDE references). Inline-annotation observation from the same Sentinel telemetry (paths in WARNING block don't carry [suppressed] inline) is NOT bundled — flagged as separate UX polish item, tracked in a follow-up issue, deferred for empirical confirmation in a future cycle before changing. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the last pending design discussion from issue #81. Resolution voted by Sentinel CHARTER-06 telemetry on issue #91: option (c)
--no-ailog-suppressonly, with the N=0 confirming-line extension.Behavior matrix
AILOG-suppressed: N path(s)block (no change)--no-ailog-suppressINFO: AILOG-aware suppression bypassed (would have suppressed: 0 paths)--no-ailog-suppressINFO:line with count + per-path list including the documenting AILOG IDThe asymmetry matches
git diff --stat— silent default, signal on explicit opt-in.Implementation
compute_ailog_suppressionsnow runs unconditionally so the count is available regardless of whether suppression is applied to the output. The flag controls only whether suppression mutates the rendered drift list.Test plan
charter_drift_no_ailog_suppress_emits_info_line_when_n_zero(the primary case the issue is about)charter_drift_no_ailog_suppress_emits_info_line_when_n_nonzero(count + per-path listing)charter_drift_default_stays_silent_when_n_zero(negative test: confirms we did NOT add noise to the common case)What's NOT in this release
[suppressed]annotation on WARNING block items (separate observation from Sentinel CHARTER-06 telemetry; tracked as follow-up issue, deferred for empirical confirmation in a future cycle before changing).charter audit(Phase 3 v1 if a real adopter requires).🤖 Generated with Claude Code