-
Notifications
You must be signed in to change notification settings - Fork 1
Several CI/Workflow changes and fixes #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Hunter T. <strangeranger@hthompson.dev>
Signed-off-by: Hunter T. <strangeranger@hthompson.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR repositions the permissions section in GitHub workflow files to follow the standard YAML structure by placing it after the name and before the on trigger sections.
- Moved
permissionssection from afterontriggers to before them in both workflow files - Updated permissions for mkdocs-deploy.yml from
contents: writetocontents: read
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/update-from-submodule.yml | Relocated permissions section to standard position |
| .github/workflows/mkdocs-deploy.yml | Relocated permissions section and changed from write to read access |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Refactor GitHub Actions workflow to separate build and deploy jobs for MkDocs. Signed-off-by: Hunter T. <strangeranger@hthompson.dev>
Added permissions for reading contents in the deployment workflow. Signed-off-by: Hunter T. <strangeranger@hthompson.dev>
Signed-off-by: Hunter T. <strangeranger@hthompson.dev>
Signed-off-by: Hunter T. <strangeranger@hthompson.dev>
Signed-off-by: Hunter T. <strangeranger@hthompson.dev>
Signed-off-by: Hunter T. <strangeranger@hthompson.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Hunter T. <strangeranger@hthompson.dev>
Signed-off-by: Hunter T. <strangeranger@hthompson.dev>
Signed-off-by: Hunter T. <strangeranger@hthompson.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.