Skip to content

Conversation

@StrangeRanger
Copy link
Owner

No description provided.

Signed-off-by: Hunter T. <strangeranger@hthompson.dev>
Signed-off-by: Hunter T. <strangeranger@hthompson.dev>
@StrangeRanger StrangeRanger changed the title Fix permissions section in update-from-submodule.yml Fix permissions section in workflows Oct 9, 2025
@StrangeRanger StrangeRanger requested a review from Copilot October 9, 2025 17:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR repositions the permissions section in GitHub workflow files to follow the standard YAML structure by placing it after the name and before the on trigger sections.

  • Moved permissions section from after on triggers to before them in both workflow files
  • Updated permissions for mkdocs-deploy.yml from contents: write to contents: read

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/update-from-submodule.yml Relocated permissions section to standard position
.github/workflows/mkdocs-deploy.yml Relocated permissions section and changed from write to read access

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Refactor GitHub Actions workflow to separate build and deploy jobs for MkDocs.

Signed-off-by: Hunter T. <strangeranger@hthompson.dev>
Added permissions for reading contents in the deployment workflow.

Signed-off-by: Hunter T. <strangeranger@hthompson.dev>
Signed-off-by: Hunter T. <strangeranger@hthompson.dev>
Signed-off-by: Hunter T. <strangeranger@hthompson.dev>
Signed-off-by: Hunter T. <strangeranger@hthompson.dev>
Signed-off-by: Hunter T. <strangeranger@hthompson.dev>
@StrangeRanger StrangeRanger changed the title Fix permissions section in workflows Several CI/Workflow changes and fixes Oct 9, 2025
@StrangeRanger StrangeRanger requested a review from Copilot October 9, 2025 18:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

StrangeRanger and others added 3 commits October 9, 2025 11:46
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Hunter T. <strangeranger@hthompson.dev>
Signed-off-by: Hunter T. <strangeranger@hthompson.dev>
Signed-off-by: Hunter T. <strangeranger@hthompson.dev>
@StrangeRanger StrangeRanger requested a review from Copilot October 9, 2025 18:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@StrangeRanger StrangeRanger merged commit 3d604de into main Oct 9, 2025
7 checks passed
@StrangeRanger StrangeRanger deleted the StrangeRanger-patch-1 branch October 9, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants