Update BaseEntityPhysics.fgd #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing output. This drove me nuts for a while til I realize Strata FGD is just missing it. I would recommend updating all of Strata's FGD entries. But this one is one I noticed.
remove p2 marker
AWildErin
requested changes
Aug 7, 2025
Member
There was a problem hiding this comment.
Something to note, BaseEntityPhysics is a cut down version of BaseEntityAnimating. Can you add the following to this file too
AllowSilentDissolve[+P2](boolean) : "Allow SilentDissolve input" : 1 : "Allow the SilentDissolve input to dissolve this object."
input Dissolve[+P2](void) : "Fizzles the object, firing the OnFizzled output."
input SilentDissolve[+P2](void) : "Kills the object immediately, firing the OnFizzled output."
Co-authored-by: Erin Sharp <sharpian126@gmail.com>
Update based on Erin's suggestions.
AWildErin
approved these changes
Aug 7, 2025
craftablescience
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing output.
This drove me nuts for a while til I realize Strata FGD is just missing it. I would recommend updating all of Strata's FGD entries. But this one is one I noticed.