Fix deleting field id null #2479
Conversation
WalkthroughRefines the divider deletion path in js/src/admin/admin.js to iterate only over list items representing actual fields (li.frm_field_box with data-fid) and delete them by their fid, then continues with toggleSectionHolder and subsequent rendering as before. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant U as User
participant UI as Admin UI
participant JS as Deletion Logic
participant F as Form Model
U->>UI: Click delete on Divider
UI->>JS: handleDividerDelete()
JS->>JS: Select li.frm_field_box[data-fid]
loop For each matched element
JS->>F: deleteField(fid)
end
JS->>UI: toggleSectionHolder()
UI->>U: Re-render updated form
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
js/src/admin/admin.js (1)
4923-4933: Defensively guard against empty settings to prevent similar errors elsewhere.If deleteField ever gets an invalid/removed ID from another call path,
settings[0]can be undefined here. A small guard makes this code resilient.function moveOpenModalsOutOfFieldOptions( settings ) { - const openModals = settings[ 0 ].querySelectorAll( '.frm-inline-modal[data-fills]' ); + if ( ! settings || ! settings.length || ! settings[ 0 ] ) { + return; + } + const openModals = settings[ 0 ].querySelectorAll( '.frm-inline-modal[data-fills]' ); if ( ! openModals.length ) { return; } openModals.forEach( modal => { modal.classList.add( 'frm_hidden' ); modal.removeAttribute( 'data-fills' ); modal.closest( 'form' ).appendChild( modal ); } ); }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
js/src/admin/admin.js(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: Cypress
- GitHub Check: PHP 8 tests in WP trunk
- GitHub Check: PHP 7.4 tests in WP trunk
- GitHub Check: PHP 8 tests in WP trunk
- GitHub Check: PHP 7.4 tests in WP trunk
- GitHub Check: Cypress
🔇 Additional comments (1)
js/src/admin/admin.js (1)
4879-4884: Good fix: filter to actual fields with data-fid before deleting.Limiting the selector to li.frm_field_box[data-fid] avoids invoking deleteField with undefined IDs and prevents the TypeError seen when deleting repeaters. This aligns with how fids are stored on field containers and keeps the deletion pass safe.
When deleting a repeater, it would try to delete elements with no
data-fid.Prevents the following error
Uncaught TypeError: can't access property "querySelectorAll", e[0] is undefined.