Fix welcome tour utms

[Crabcyborg]

It looks like the welcome tour was merged after we made some major UTM changes, so these are totally wrong.

So we don't have to have all of these strings hard coded here, which is the main issue, I'm calling maybe_add_missing_utm now.

[coderabbitai]

Walkthrough

The make_tracked_url method in FrmWelcomeTourController has been refactored to delegate UTM parameter handling to FrmAppHelper helper methods instead of manually constructing and appending them, consolidating the URL building logic.

Changes

Cohort / File(s)	Summary
URL tracking refactor classes/controllers/FrmWelcomeTourController.php	Refactored make_tracked_url to use FrmAppHelper::maybe_add_missing_utm with campaign 'welcome-tour' and FrmAppHelper::make_affiliate_url instead of manually building UTM parameters and using add_query_arg

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Areas requiring attention:
  • Verify that FrmAppHelper::maybe_add_missing_utm with campaign 'welcome-tour' produces equivalent UTM parameters to the previous manual construction
  • Confirm FrmAppHelper::make_affiliate_url handles the URL correctly after UTM injection
  • Check all call sites of make_tracked_url to ensure behavior remains unchanged
  • Review helper method implementations to understand any side effects or edge cases

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Fix welcome tour utms' directly addresses the main change: correcting UTM parameters in the welcome tour controller, which aligns with the refactoring described in the summary.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Description check	✅ Passed	The pull request description clearly explains the issue (wrong UTM strings after a merge) and the solution (using maybe_add_missing_utm instead of hard-coded strings), directly relating to the code changes in FrmWelcomeTourController.php.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix_welcome_tour_utms

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[shervElmi]

It looks good to me. 🚀

Thanks Mike!

[Crabcyborg]

Thanks Sherv!