Skip to content

Conversation

@Crabcyborg
Copy link
Contributor

@Crabcyborg Crabcyborg commented Nov 28, 2025

This came up in a review. I'd rather not have to bring this up in review, but I want it to be consistent.

@Crabcyborg Crabcyborg changed the title Udate phpcs fixer to disallow else if Update phpcs fixer to disallow else if Nov 28, 2025
@Crabcyborg Crabcyborg added this to the 6.26 milestone Nov 28, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 28, 2025

Walkthrough

The change enables the PHP CS Fixer 'elseif' rule in the project configuration, adding it to the existing ruleset. This affects how elseif constructs are formatted and normalized during code style fixing.

Changes

Cohort / File(s) Summary
PHP CS Fixer Configuration
\.php-cs-fixer\.php
Enable the 'elseif' rule to enforce consistent formatting of elseif constructs

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title mentions disallowing 'else if' which aligns with the elseif rule addition, but also references 'phpdoc tags' which is not present in the changeset. Update the title to focus on the actual change: enabling the PHP CS Fixer 'elseif' rule. Remove the reference to phpdoc tag separation as it's not implemented in this changeset.
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The description is related to the changeset, indicating the motivation behind enforcing consistent code style for elseif constructs to reduce review comments.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch phpcs_fixer_no_else_if

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Crabcyborg Crabcyborg changed the title Update phpcs fixer to disallow else if Update phpcs fixer to disallow else if and enforce separation of phpdoc tags Nov 28, 2025
@Crabcyborg Crabcyborg merged commit 7edf70e into master Nov 28, 2025
16 checks passed
@Crabcyborg Crabcyborg deleted the phpcs_fixer_no_else_if branch November 28, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants