Apple pay (PayPal) by Crabcyborg · Pull Request #3050 · Strategy11/formidable-forms

Crabcyborg · 2026-03-30T15:27:31Z

No description provided.

deepsource-io · 2026-03-30T15:28:39Z

DeepSource Code Review

We reviewed changes in c1b60ed...36b9640 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

Important

Some issues found as part of this review are outside of the diff in this pull request and aren't shown in the inline review comments due to GitHub's API limitations. You can see those issues on the DeepSource dashboard.

PR Report Card

Overall Grade	Security Reliability Complexity Hygiene

Code Review Summary

Analyzer	Status	Updated (UTC)	Details
PHP		Mar 30, 2026 3:37p.m.	Review ↗
JavaScript		Mar 30, 2026 3:37p.m.	Review ↗

coderabbitai · 2026-03-30T15:29:08Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 34f85698-1265-4e0d-9c6f-b8991e2e8e75

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch apple_pay

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

deepsource-io · 2026-03-30T15:29:22Z

paypal/js/frontend.js

+					render: renderApplePayButton
+				} );
+			} else {
+				console.log( 'Apple Pay not available:', applePayEligibilityResult );


Avoid using console in code that runs on the browser

It is considered a best practice to avoid the use of any console methods in JavaScript code that will run on the browser.

NOTE: If your repository contains a server side project, you can add "nodejs" to the environment property of analyzer meta in .deepsource.toml.
This will prevent this issue from getting raised.
Documentation for the analyzer meta can be found here.
Alternatively, you can silence this issue for your repository as shown here.

If a specific console call is meant to stay for other reasons, you can add a skipcq comment to that line.
This will inform other developers about the reason behind the log's presence, and prevent DeepSource from flagging it.

deepsource-io · 2026-03-30T15:29:23Z

paypal/js/frontend.js

+		// Use paypal.Applepay().config() as the definitive eligibility check (per PayPal multiparty docs).
+		try {
+			applePayConfig = await paypal.Applepay().config();
+			console.log( '[FrmApplePay] config() response:', JSON.stringify( applePayConfig, null, 2 ) );


Avoid using console in code that runs on the browser

It is considered a best practice to avoid the use of any console methods in JavaScript code that will run on the browser.

NOTE: If your repository contains a server side project, you can add "nodejs" to the environment property of analyzer meta in .deepsource.toml.
This will prevent this issue from getting raised.
Documentation for the analyzer meta can be found here.
Alternatively, you can silence this issue for your repository as shown here.

If a specific console call is meant to stay for other reasons, you can add a skipcq comment to that line.
This will inform other developers about the reason behind the log's presence, and prevent DeepSource from flagging it.

deepsource-io · 2026-03-30T15:29:23Z

paypal/js/frontend.js

+			}
+		} catch ( err ) {
+			console.error( '[FrmApplePay] config() threw error:', err );
+			return 'Apple Pay config check failed: ' + err.message;


Unexpected string concatenation

In ES2015 (ES6), we can use template literals instead of string concatenation.

deepsource-io · 2026-03-30T15:29:23Z

paypal/js/frontend.js

+	async function renderApplePayButton() {
+		const method = paymentMethods.get( 'apple_pay' );
+		if ( ! method ) {
+			return;
+		}
+
+		const container = method.containerEl;
+		container.innerHTML = '';
+
+		const btn = document.createElement( 'apple-pay-button' );
+		btn.setAttribute( 'buttonstyle', 'black' );
+		btn.setAttribute( 'type', 'buy' );
+		btn.setAttribute( 'locale', 'en' );
+		btn.style.width = '100%';
+		btn.style.height = '40px';
+
+		btn.addEventListener( 'click', onApplePayButtonClick );
+		container.appendChild( btn );
+	}


Found `async` function without any `await` expressions

A function that does not contain any await expressions should not be async (except for some edge cases in TypeScript which are discussed below). Asynchronous functions in JavaScript behave differently than other functions in two important ways:

deepsource-io · 2026-03-30T15:29:23Z

paypal/js/frontend.js

+			createOrderForApplePay()
+				.then( ( orderId ) => {
+					return applepay.confirmOrder( {
+						orderId: orderId,


Expected property shorthand

ECMAScript 6 provides a concise form for defining object literal methods and properties. This syntax can make defining complex object literals much cleaner.

deepsource-io · 2026-03-30T15:29:23Z

paypal/js/frontend.js

+	 */
+	function getFormTotal() {
+		const totalField = thisForm.querySelector( '[data-frmtotal]' );
+		if ( totalField && totalField.value ) {


Prefer using an optional chain expression instead, as it's more concise and easier to read

The optional chaining operator can be used to perform null checks before accessing a property, or calling a function.

Crabcyborg added 2 commits March 30, 2026 10:43

Working on Apple Pay (wip)

069da46

Get apple pay button appearing

30e279c

Crabcyborg changed the base branch from master to paypal March 30, 2026 15:27

deepsource-io bot reviewed Mar 30, 2026

View reviewed changes

Remove some logging

3039bcc

Crabcyborg changed the title ~~Apple pay~~ Apple pay (PayPal) Mar 30, 2026

Drop unused var

36b9640

Crabcyborg merged commit bf25dc1 into paypal Mar 30, 2026
14 of 15 checks passed

Crabcyborg deleted the apple_pay branch March 30, 2026 15:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Apple pay (PayPal)#3050

Apple pay (PayPal)#3050
Crabcyborg merged 4 commits intopaypalfrom
apple_pay

Crabcyborg commented Mar 30, 2026

Uh oh!

deepsource-io bot commented Mar 30, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Mar 30, 2026 •

edited

Loading

Review skipped

Uh oh!

deepsource-io bot Mar 30, 2026

Uh oh!

deepsource-io bot Mar 30, 2026

Uh oh!

deepsource-io bot Mar 30, 2026

Uh oh!

deepsource-io bot Mar 30, 2026

Uh oh!

deepsource-io bot Mar 30, 2026

Uh oh!

deepsource-io bot Mar 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Crabcyborg commented Mar 30, 2026

Uh oh!

deepsource-io bot commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

DeepSource Code Review

PR Report Card

Code Review Summary

Uh oh!

coderabbitai bot commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

deepsource-io bot Mar 30, 2026

Choose a reason for hiding this comment

Avoid using console in code that runs on the browser

Uh oh!

deepsource-io bot Mar 30, 2026

Choose a reason for hiding this comment

Avoid using console in code that runs on the browser

Uh oh!

deepsource-io bot Mar 30, 2026

Choose a reason for hiding this comment

Unexpected string concatenation

Uh oh!

deepsource-io bot Mar 30, 2026

Choose a reason for hiding this comment

Found `async` function without any `await` expressions

Uh oh!

deepsource-io bot Mar 30, 2026

Choose a reason for hiding this comment

Expected property shorthand

Uh oh!

deepsource-io bot Mar 30, 2026

Choose a reason for hiding this comment

Prefer using an optional chain expression instead, as it's more concise and easier to read

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

deepsource-io bot commented Mar 30, 2026 •

edited

Loading

coderabbitai bot commented Mar 30, 2026 •

edited

Loading