Skip to content

Rock/form actions a11y keyboard nav#3078

Merged
Crabcyborg merged 14 commits intorock/form-actions-refreshfrom
rock/form-actions-a11y-keyboard-nav
Apr 27, 2026
Merged

Rock/form actions a11y keyboard nav#3078
Crabcyborg merged 14 commits intorock/form-actions-refreshfrom
rock/form-actions-a11y-keyboard-nav

Conversation

@shervElmi
Copy link
Copy Markdown
Contributor

@shervElmi shervElmi requested a review from Crabcyborg April 15, 2026 14:39
@shervElmi shervElmi self-assigned this Apr 15, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 15, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: eceab057-59b6-4169-81d1-28aa1f64e899

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch rock/form-actions-a11y-keyboard-nav

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@deepsource-io
Copy link
Copy Markdown

deepsource-io Bot commented Apr 15, 2026

DeepSource Code Review

We reviewed changes in 3f3dca6...52eb87a on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

Code Review Summary

Analyzer Status Updated (UTC) Details
PHP Apr 15, 2026 2:39p.m. Review ↗
JavaScript Apr 15, 2026 2:39p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

Comment thread classes/views/frm-form-actions/form_action.php
Comment thread classes/views/frm-form-actions/_action_icon.php
@deepsource-io
Copy link
Copy Markdown

deepsource-io Bot commented Apr 15, 2026

DeepSource Code Review

We reviewed changes in c165cff...5f28e5a on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

Important

Some issues found as part of this review are outside of the diff in this pull request and aren't shown in the inline review comments due to GitHub's API limitations. You can see those issues on the DeepSource dashboard.

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
PHP Apr 27, 2026 1:33p.m. Review ↗
JavaScript Apr 27, 2026 1:33p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

Copy link
Copy Markdown
Contributor

@Crabcyborg Crabcyborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shervElmi!

I haven't tested these yet but I think these changes look good.

I'll go ahead and merge so everything is in the one branch.

@Crabcyborg Crabcyborg merged commit 9e21964 into rock/form-actions-refresh Apr 27, 2026
17 of 19 checks passed
@Crabcyborg Crabcyborg deleted the rock/form-actions-a11y-keyboard-nav branch April 27, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants