Skip to content

Fix DeepSource Warnings #3080

Merged
Crabcyborg merged 31 commits intorock/form-actions-refreshfrom
rock/form-actions-refresh-deepsource-phpdocs
Apr 22, 2026
Merged

Fix DeepSource Warnings #3080
Crabcyborg merged 31 commits intorock/form-actions-refreshfrom
rock/form-actions-refresh-deepsource-phpdocs

Conversation

@shervElmi
Copy link
Copy Markdown
Contributor

DeepSource was flagging view templates for undefined variables because those variables are actually passed in from the including controller. This adds PHPDoc headers to document the inherited variables so that DeepSource (and IDEs) can understand the template context.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 17, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a3d3867a-3444-4226-9163-b41a2ebf3de0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch rock/form-actions-refresh-deepsource-phpdocs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@deepsource-io
Copy link
Copy Markdown

deepsource-io Bot commented Apr 17, 2026

DeepSource Code Review

We reviewed changes in 972f6d4...2e532f2 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

Important

Some issues found as part of this review are outside of the diff in this pull request and aren't shown in the inline review comments due to GitHub's API limitations. You can see those issues on the DeepSource dashboard.

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
PHP Apr 21, 2026 11:51a.m. Review ↗
JavaScript Apr 21, 2026 11:51a.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (rock/form-actions-refresh@972f6d4). Learn more about missing BASE report.

Additional details and impacted files
@@                     Coverage Diff                      @@
##             rock/form-actions-refresh    #3080   +/-   ##
============================================================
  Coverage                             ?   26.43%           
  Complexity                           ?     9127           
============================================================
  Files                                ?      149           
  Lines                                ?    30733           
  Branches                             ?        0           
============================================================
  Hits                                 ?     8124           
  Misses                               ?    22609           
  Partials                             ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread classes/views/frm-entries/_sidebar-shared-pub.php
Comment thread classes/views/frm-entries/show.php
@shervElmi shervElmi requested a review from Crabcyborg April 17, 2026 17:26
@shervElmi shervElmi marked this pull request as ready for review April 17, 2026 17:26
@shervElmi shervElmi changed the title Add PHPDoc headers to fix DeepSource view warnings Fix DeepSource Warnings Apr 20, 2026
Comment thread .github/workflows/mago.yml Outdated
Comment thread classes/views/frm-fields/back-end/settings.php Outdated
Comment thread js/src/admin/admin.js Outdated
Comment thread phpstan.neon Outdated
Comment thread classes/views/frm-entries/sidebar-shared.php Outdated
Comment thread classes/views/frm-fields/back-end/field-credit-card.php Outdated
Comment thread classes/views/frm-fields/back-end/default-value-field.php Outdated
@shervElmi shervElmi requested a review from Crabcyborg April 21, 2026 11:32
Copy link
Copy Markdown
Contributor

@Crabcyborg Crabcyborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @shervElmi!

I think these changes look good!

🚀

@Crabcyborg Crabcyborg added this to the 6.31 (PayPal Commerce) milestone Apr 22, 2026
@Crabcyborg Crabcyborg merged commit d97c89d into rock/form-actions-refresh Apr 22, 2026
19 checks passed
@Crabcyborg Crabcyborg deleted the rock/form-actions-refresh-deepsource-phpdocs branch April 22, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants