Skip to content

Set slider input min height#3118

Merged
Crabcyborg merged 1 commit into
masterfrom
set_slider_input_min_height
Jun 1, 2026
Merged

Set slider input min height#3118
Crabcyborg merged 1 commit into
masterfrom
set_slider_input_min_height

Conversation

@Crabcyborg

@Crabcyborg Crabcyborg commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Before
Screen Shot 2026-06-01 at 2 58 33 PM

After
Screen Shot 2026-06-01 at 2 57 18 PM

Summary by CodeRabbit

Release Notes

  • Style
    • Refined range slider component styling and form input field sizing for improved visual consistency across the settings interface.
    • Updated minimum height constraints on slider input controls for better form element alignment.

@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 79d7ed72-b06a-4f74-af43-f3f6dfe0efb4

📥 Commits

Reviewing files that changed from the base of the PR and between 848d109 and de26e4d.

📒 Files selected for processing (4)
  • css/admin/frm-settings-components.css
  • js/formidable_admin.js
  • js/src/web-components/frm-range-slider-component/frm-range-slider-component.css
  • resources/scss/admin/components/settings/_sliders.scss

📝 Walkthrough

Walkthrough

This PR reduces the minimum height of slider value input controls from an implicit larger value (40px) to an explicit 34px. Changes span the SCSS source file and its compiled CSS output, plus a web component stylesheet, to apply the height constraint consistently across the admin settings and component layers.

Changes

Slider value input height adjustments

Layer / File(s) Summary
Reduce slider value input min-height to 34px
resources/scss/admin/components/settings/_sliders.scss, js/src/web-components/frm-range-slider-component/frm-range-slider-component.css, css/admin/frm-settings-components.css
Added min-height: 34px to .frm-slider-value input styling in the SCSS source to explicitly override conflicting CSS; the compiled range-slider component CSS and regenerated admin settings CSS apply the same constraint.

🎯 1 (Trivial) | ⏱️ ~3 minutes

🐰 A hop, skip, and a style fix,
Sliders now sit just right,
Thirty-four pixels of pure delight!
No more fighting with heights,
Our form inputs glow bright.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly describes the main change: setting a minimum height constraint on slider input elements across multiple stylesheets.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch set_slider_input_min_height

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@deepsource-io

deepsource-io Bot commented Jun 1, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 848d109...de26e4d on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
PHP Jun 1, 2026 5:58p.m. Review ↗
JavaScript Jun 1, 2026 5:58p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@Crabcyborg Crabcyborg merged commit b7d225a into master Jun 1, 2026
47 of 48 checks passed
@Crabcyborg Crabcyborg deleted the set_slider_input_min_height branch June 1, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant