-
Notifications
You must be signed in to change notification settings - Fork 30
Add GithubPlugin 1.1.1-alpha to Plugins.json #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Amazing work! Any particular reason you're writing the changes manually to |
The set_settings and get_settings functions currently update settings on a per-button basis. Since users will have 6–7 buttons, I’d like to avoid requiring them to enter their API credentials multiple times. Is there a better way to share or synchronize the settings across multiple buttons? |
You can use the methods of the plugin manager. For an example you can checkout: https://github.com/StreamController/OBSPlugin/blob/bd2cfc343ed55f53612d9ccc83f0a8fbe91e779a/OBSActionBase.py#L58-L61 |
|
Thanks, i'll try this method and push the change since my method is insecure. |
👍 Just ping me when you're ready. |
|
@Core447 , I updated the code to use plugin-level settings. When I have two buttons, updating the settings on one does update the other — but it doesn’t trigger an API refresh on the second button. I have to navigate away and back for it to reload. |
There is, but it's not really nice to trigger a reload. I would suggest to just check the settings periodically through |
|
@Core447, Thank you — Side note: Would it be possible to add on_tick to the Plugin Development guide? Could be helpful for others getting started. |
It's under ActionBase: https://streamcontroller.core447.com/streamcontroller/docs/latest/plugin_dev/bases/ActionBase_py/?h=on_tick#on_tick But yeah, it's easy to miss |
|
What's your name on discord so that I can mention you in the release announcement? |
|
@Core447, My discord name is: Code Ninja |
Checks