Merged
Conversation
Member
Author
There was a problem hiding this comment.
To fix npm test. Lint was breaking and actual tests never ran. Looks like the travis setup is broken, but they run locally for me now.
Member
|
Would love to have some tests for these changes. Think you can do that? If not that's fine, just let me know. |
Member
|
If you can do tests, just submit another PR. I'm also going to add you as a collaborator 😄 |
Member
Author
|
Absolutely, I'll add some this afternoon. Thanks! |
Member
Author
|
How would you feel about switching to protractor for integration tests? It's pretty difficult to test angular stuff with bare |
Member
|
Totally for it, protractor is like defacto in the angular community right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds project access level checks to web socket requests and UI controls, and enables "run" level access for collaborators. Read-only collaborators are no longer allowed to run jobs.