job was aborting if strider.json file could not be retrieved

[brandon-bethke-timu]

Today I downloaded strider-cd for the first time and attempting to setup a build using the default runner and basic strider-git plugin. However when testing, the build would always fail immediately and the strider server console would only print:

job.prepare - error opening/processing project's `strider.json` file: [Error: not implemented]

I traced this to the lib/backchannel.js file and noticed that the else statement on line 85 is returning and preventing the build from running. So being confused why a basic example didn't work and not knowing what to do, I copied the pattern from the if and else if statements directly above, which are also handling errors related to strider.json, and just initialized the config and unset the fromStriderJson flag.

Please review and merge.

[xdissent]

👍

[bitwit]

Interesting... I would love to know reproducible steps for this. We're on 1.7.2 at work, never use strider.json in our projects and haven't seen any issue.
Funny to be running in to the problem so quickly as a Strider newcomer. The fix looks legit; I'm just confused why this isn't happening all the time for anyone not using strider.json

[oliversalzburg]

Usually, the contents of the strider.json would just be merged with the job configuration. The error you're seeing shouldn't be fatal. I would expect that there's something going wrong somewhere else.

On second thought, I guess most people are using a provider like GitHub, Bitbucket or GitLab, which have special support for retrieving single files through an API before even checking out the project. This is obviously not possible with the basic git provider.

[xdissent]

The strider-git provider doesn't implement retrieving the file: https://github.com/Strider-CD/strider-git/blob/master/webapp.js#L37

[knownasilya]

Agreed, this should have been the response to begin with.

[bitwit]

ahhh, we've been using strider-github not strider-git at work, good call @xdissent .