Fetching strider.json from a Github repository is broken#914
Merged
knownasilya merged 1 commit intoStrider-CD:masterfrom Feb 12, 2016
Merged
Fetching strider.json from a Github repository is broken#914knownasilya merged 1 commit intoStrider-CD:masterfrom
strider.json from a Github repository is broken#914knownasilya merged 1 commit intoStrider-CD:masterfrom
Conversation
knownasilya
pushed a commit
that referenced
this pull request
Feb 12, 2016
Fetching `strider.json` from a Github repository is broken
Member
|
Excellent! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fetching
strider.jsonis currently broken, at least when the provider of the repository is Github.I tracked that down to
striderJson()inlib/backchannel.jsnot passing the credentials toprovider.getFile. Usingaccount.configinstead of justaccountmakes it work, and is consistent with what is done when calling other provider functions (for example the call toprovider.getBranches()inlib/routes/index.js.