Fix hard-coded admin notification email address#951
Merged
knownasilya merged 1 commit intoStrider-CD:masterfrom Jul 8, 2016
oliversalzburg:fix/admin-email
Merged
Fix hard-coded admin notification email address#951knownasilya merged 1 commit intoStrider-CD:masterfrom oliversalzburg:fix/admin-email
knownasilya merged 1 commit intoStrider-CD:masterfrom
oliversalzburg:fix/admin-email
Conversation
Contributor
Author
|
Should probably be merged and published ASAP, but could be considered a breaking change :P |
| } | ||
|
|
||
| function getAdmins(done) { | ||
| User.find({ account_level: 1 }, function (err, admins) { |
Member
There was a problem hiding this comment.
Would this also send an email to the newly created user (if it's an admin)? Seems like that user should be ignored.
Contributor
Author
|
Should be better now |
Member
|
I think it's time to cut a release 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #950