enhance: update combobox label in 'reporting' page#241
Merged
Conversation
- update database query to include subjects each teacher teaches - update label to follow the format 'TeacherFullName (Subject 1, Subject 2,...)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the user experience on the public absence reporting page by enriching the
Comboboxdropdown choices. It adds contextual subject descriptions alongside teacher names, making it easier for teachers to identify themselves should there be other teachers with identical or similar names.Key Changes
page.tsx) to pull the subjects relation/field for the dropdown data set.Comboboxmapping options to concatenate the teacher's full name with their respective assigned subjects, matching the specification:TeacherFullName (Subject 1, Subject 2, ...).Comboboxoption value attribute continues to map directly to the clean database primary key ID (teacher.id).Manual Verification Steps
Your namedropdown.Fixes #232