Fix premature pin on failed profile add

[Copilot]

handleAddExistingApp was calling togglePinnedApp before awaiting the /api/profile/add-app response. On API failure, the app stayed pinned on the homepage despite never being added to the profile.

Change

Move togglePinnedApp to execute only after addAppToProfile returns true:

// Before
const alreadyPinned = preferences.pinnedApps?.includes(appId);
if (!alreadyPinned) togglePinnedApp(appId);          // ← runs unconditionally

const added = await addAppToProfile(appId);
if (!added) { addToast('Failed to add app to profile', 'error'); return false; }

// After
const added = await addAppToProfile(appId);
if (!added) { addToast('Failed to add app to profile', 'error'); return false; }

const alreadyPinned = preferences.pinnedApps?.includes(appId);
if (!alreadyPinned) togglePinnedApp(appId);          // ← runs only on success

Pin state is now only updated when the API call confirms the app was successfully added to the profile.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
string-v2	Ready	Preview, Comment	Mar 3, 2026 3:24pm

[Copilot]

Pull request overview

Prevents the homepage pin state from being updated when adding an existing app to a personal profile fails, ensuring UI state reflects the actual server-side outcome.

Changes:

• Reorders handleAddExistingApp so the profile add API call is awaited before pinning.
• Keeps the existing “only pin if not already pinned” behavior, but now only after a successful add.
• Preserves existing success/failure toast behavior and profile reload on success.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.