Fix unsound return type on normalizeOpalLogo#47
Merged
ghostleek merged 2 commits intofix/show-profilefrom Mar 4, 2026
Merged
Conversation
Merged
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: ghostleek <44336310+ghostleek@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Work in progress to address feedback on 'Fix/show profile' PR
Fix unsound return type on Mar 4, 2026
normalizeOpalLogo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
normalizeOpalLogowas declared to returnT, implying the output type is identical to the input — but the function mutateslogoUrl, making the signature unsound for anyTwith a narrowerlogoUrltype.Change
Return type widened to accurately reflect the mutation:
This ensures downstream code sees
logoUrlasstring | nullrather than inheriting a potentially narrower type fromT.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.