Simplified serialization process for components (table and chat)#479
Open
ShadowMasterAJ wants to merge 1 commit intoStructuredLabs:mainfrom
Open
Simplified serialization process for components (table and chat)#479ShadowMasterAJ wants to merge 1 commit intoStructuredLabs:mainfrom
ShadowMasterAJ wants to merge 1 commit intoStructuredLabs:mainfrom
Conversation
Member
|
@ShadowMasterAJ , is this overlapping w/ pr #470 ? Could you close this or the other one? I'll review and merge shortly after that |
13 tasks
11b79a0 to
3c1a0fb
Compare
Member
|
@ShadowMasterAJ can you rebase this on main and check if it still works? And can you attach a screen recording of it working? |
ace7a22 to
d33b7fb
Compare
d33b7fb to
c3c623e
Compare
Contributor
Author
|
The commit includes all the latest changes. Working example below preswald_ser.mp4 |
2642ec5 to
510172f
Compare
Contributor
Author
|
Rebased changes onto latest. Ready for merge @shivam-singhal |
6ac1dad to
bdb2c4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Create a pull request to contribute to the project
title: ''
labels: ''
assignees: ''
Fixes
#650
#664
Description of Changes
Made serialization in components (table and chat) more organized and reduced code.
Type of Change
Testing
Tested with all 4 examples
Checklist