Skip to content

Simplified serialization process for components (table and chat)#479

Open
ShadowMasterAJ wants to merge 1 commit intoStructuredLabs:mainfrom
ShadowMasterAJ:enhancement/serialization
Open

Simplified serialization process for components (table and chat)#479
ShadowMasterAJ wants to merge 1 commit intoStructuredLabs:mainfrom
ShadowMasterAJ:enhancement/serialization

Conversation

@ShadowMasterAJ
Copy link
Contributor

@ShadowMasterAJ ShadowMasterAJ commented Mar 20, 2025


name: Pull Request
about: Create a pull request to contribute to the project
title: ''
labels: ''
assignees: ''

Fixes
#650
#664

Description of Changes
Made serialization in components (table and chat) more organized and reduced code.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • New example
  • Test improvement
  • Code Quality Improvement

Testing
Tested with all 4 examples

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have run my code against examples and ensured no errors
  • Any dependent changes have been merged and published in downstream modules

@shivam-singhal
Copy link
Member

@ShadowMasterAJ , is this overlapping w/ pr #470 ? Could you close this or the other one? I'll review and merge shortly after that

@ShadowMasterAJ ShadowMasterAJ marked this pull request as draft March 24, 2025 23:29
@ShadowMasterAJ ShadowMasterAJ force-pushed the enhancement/serialization branch from 11b79a0 to 3c1a0fb Compare March 27, 2025 19:14
@ShadowMasterAJ ShadowMasterAJ marked this pull request as ready for review March 27, 2025 23:11
@shivam-singhal
Copy link
Member

@ShadowMasterAJ can you rebase this on main and check if it still works? And can you attach a screen recording of it working?

@ShadowMasterAJ ShadowMasterAJ force-pushed the enhancement/serialization branch 5 times, most recently from ace7a22 to d33b7fb Compare April 4, 2025 06:17
@ShadowMasterAJ ShadowMasterAJ force-pushed the enhancement/serialization branch from d33b7fb to c3c623e Compare April 4, 2025 06:20
@ShadowMasterAJ ShadowMasterAJ reopened this Apr 4, 2025
@ShadowMasterAJ
Copy link
Contributor Author

ShadowMasterAJ commented Apr 4, 2025

The commit includes all the latest changes. Working example below

preswald_ser.mp4

@ShadowMasterAJ ShadowMasterAJ force-pushed the enhancement/serialization branch from 2642ec5 to 510172f Compare April 13, 2025 00:01
@ShadowMasterAJ
Copy link
Contributor Author

Rebased changes onto latest. Ready for merge @shivam-singhal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants