Add Linux whisper-cli add-on source#16
Merged
Merged
Conversation
Point the app at the self-built linux-x64/arm64 whisper-cli tarballs
published to the whisper-v1.8.3 release (format: tar, extracted to
whisper/bin/whisper-cli). This lets Linux users download the whisper
subtitle add-on at runtime, matching macOS (Homebrew bottle) and
Windows (upstream release zip).
Also fix build-whisper.yml: the build jobs don't check out the repo, so
gh release commands had no git remote to infer from ("not a git
repository"). Set GH_REPO explicitly so future runs publish correctly.
(The v1.8.3 release was created manually from this run's artifacts.)
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The Linux test job built whisper.cpp from source, but the app never does that — it downloads the prebuilt whisper-cli add-on at runtime. Now that whisper-addon.json has a linux-x64 source, the test downloads that same published tarball (URL read from the JSON so it can't drift), exercising the real artifact + tar layout. Mirrors the Windows job, which curls its release zip. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
StuartCameronCode
force-pushed
the
whisper-linux-addon
branch
2 times, most recently
from
ea663bd to
f2b40f3
Compare
Distinguish the Rust worker tests (cargo test), the Flutter test/ suite (the CI gate), and the Flutter integration_test/ suite (local-only, not in CI — Flutter routes it through the device launcher, and it has drifted out of sync with the models). Update the CI gate description to include the Linux x64 job and the per-platform whisper-cli provisioning. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes whisper subtitle support on Linux. The branch that added Linux support wired the
isLinuxpaths inwhisper_addon_manager, butwhisper-addon.jsonhad no Linux source — so Linux users couldn't download the whisper-cli add-on at runtime (whisper.cpp publishes no Linux binary).whisper-addon.json: addlinux-x64andlinux-arm64entries (format: tar,executable: whisper-cli) pointing at the newwhisper-v1.8.3release tarballs, with size + sha256.build-whisper.ymlfix: the build jobs don'tactions/checkout, sogh releasehad no git remote to infer the repo from (fatal: not a git repository). SetGH_REPOexplicitly so future runs publish correctly.The
tarextraction handler (whisper/bin/whisper-cli) already merged with the workflow in #15.Artifacts (already published to
whisper-v1.8.3)Built by
build-whisper.yml(static, glibc-only, Ubuntu 22.04+ / glibc ≥ 2.35), verified to run with onlylibc/libm/lddeps:whisper-cli-linux-x64.tar.gz— 1,573,360 byteswhisper-cli-linux-arm64.tar.gz— 1,527,325 bytes (ARM aarch64 ELF)Note
The release was created manually from the build run's artifacts because the upload step failed on the missing
GH_REPO(now fixed). Re-runningbuild-whisper.ymlwill reproduce/refresh the release cleanly.🤖 Generated with Claude Code