Skip to content

Sync upstream Patchright and reapply custom fixes#6

Merged
OFShare merged 26 commits intomainfrom
users/ofshare/sync-upstream-and-reapply-fixes
Apr 21, 2026
Merged

Sync upstream Patchright and reapply custom fixes#6
OFShare merged 26 commits intomainfrom
users/ofshare/sync-upstream-and-reapply-fixes

Conversation

@OFShare
Copy link
Copy Markdown
Collaborator

@OFShare OFShare commented Apr 20, 2026

Summary

  • Sync with upstream Kaliiiiiiiiii-Vinyzu/patchright latest changes (TypeScript refactor,
    v1.59.x support)
  • Reapply two custom fixes on the new .ts patch files:
    • Edge NTP crash fix: skip Fetch.fulfillRequest for privilege pages (ntp.msn) that cause
      Edge to crash
    • expose_binding fix: remove runIfWaitingForDebugger from promises to avoid page click
      stuck on Windows

Test plan

  • Run local_build.ps1 -PlaywrightVersion "v1.59.1" to verify patches apply cleanly
  • Test Edge browser with new tab page to verify NTP crash fix
  • Test exposeBinding to verify no page click stuck on Windows

Vinyzu and others added 25 commits March 22, 2026 19:40
…nyzu#180)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Vinyzu <50874994+Vinyzu@users.noreply.github.com>
- Edge NTP crash: skip Fetch.fulfillRequest for privilege pages (ntp.msn)
- expose_binding: remove runIfWaitingForDebugger from promises to avoid page click stuck on Windows

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@OFShare OFShare temporarily deployed to pr-artifact-build April 20, 2026 08:41 — with GitHub Actions Inactive
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 20, 2026

Patchright Driver Build
Do not download or use these artifacts in production! They are only for testing purposes on this Pull Request.

Download

Debug info

  • Artifact ID: 6545978692
  • Head SHA: 699c3770638cf77b8735d8f21497236d63c1fd26

The full removal of runIfWaitingForDebugger caused popup tests to hang.
Restore upstream's conditional logic which defers the call only when
pageBindings exist. Only Edge NTP crash fix is kept as custom change.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@OFShare OFShare deployed to pr-artifact-build April 21, 2026 02:41 — with GitHub Actions Active
@OFShare OFShare merged commit a260a34 into main Apr 21, 2026
2 checks passed
github-actions Bot pushed a commit that referenced this pull request Apr 21, 2026
…ntWan/users/ofshare/sync-upstream-and-reapply-fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants