Skip to content

refactor(gui): group board state flags into typed state objects#108

Merged
StudentWeis merged 2 commits into
mainfrom
refactor/board-state-objects
May 9, 2026
Merged

refactor(gui): group board state flags into typed state objects#108
StudentWeis merged 2 commits into
mainfrom
refactor/board-state-objects

Conversation

@StudentWeis
Copy link
Copy Markdown
Owner

Summary

Refactor board and settings state into grouped state objects so the board logic reads in terms of domain state instead of scattered top-level flags.

Linked Issue

Closes #107

Changes

  • group board UI and search-related flags into UiState and FilterState
  • group settings editor booleans into nested state structs and update dependent call sites
  • replace row render booleans with typed render flags for clearer conditional rendering

Testing

  • scripts/precheck.sh passes locally
  • New / updated tests cover the change
  • cargo test --quiet board

Self-Check

  • PR title follows Conventional Commits
  • No hardcoded user-facing strings — i18n keys added to all locale files
  • New UI components use gpui-component
  • Errors defined with thiserror (no manual impl Display/Error)
  • No unrelated changes mixed in

@StudentWeis StudentWeis merged commit 22ca38b into main May 9, 2026
8 checks passed
@StudentWeis StudentWeis deleted the refactor/board-state-objects branch May 9, 2026 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: group board state flags into typed state objects

1 participant