Skip to content

refactor(updater): remove hex dependency#119

Merged
StudentWeis merged 1 commit into
mainfrom
refactor/remove-hex-dependency
May 11, 2026
Merged

refactor(updater): remove hex dependency#119
StudentWeis merged 1 commit into
mainfrom
refactor/remove-hex-dependency

Conversation

@StudentWeis
Copy link
Copy Markdown
Owner

Summary

Remove the updater module's dependency on the external hex crate by encoding SHA-256 digests locally.

Linked Issue

Closes #118

Changes

  • replace hex::encode in the updater checksum path with a small local lowercase hex encoder
  • remove the unused hex dependency from the crate manifest and lockfile

Testing

  • scripts/precheck.sh passes locally
  • New / updated tests cover the change
  • existing compute_sha256_hex_reads_file_content_expected test continues to validate the exact checksum output

Self-Check

  • PR title follows Conventional Commits
  • No hardcoded user-facing strings — i18n keys added to all locale files
  • New UI components use gpui-component
  • Errors defined with thiserror (no manual impl Display/Error)
  • No unrelated changes mixed in

@StudentWeis StudentWeis merged commit 9531170 into main May 11, 2026
8 checks passed
@StudentWeis StudentWeis deleted the refactor/remove-hex-dependency branch May 11, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: remove hex dependency from updater checksum

1 participant