refactor(updater): remove hex dependency#119
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the updater module's dependency on the external
hexcrate by encoding SHA-256 digests locally.Linked Issue
Closes #118
Changes
hex::encodein the updater checksum path with a small local lowercase hex encoderhexdependency from the crate manifest and lockfileTesting
scripts/precheck.shpasses locallycompute_sha256_hex_reads_file_content_expectedtest continues to validate the exact checksum outputSelf-Check
gpui-componentthiserror(no manualimpl Display/Error)