Skip to content

refactor(config): inline validate.rs into settings.rs and remove settings/ folder#123

Merged
StudentWeis merged 1 commit into
mainfrom
refactor/flatten-config-settings
May 11, 2026
Merged

refactor(config): inline validate.rs into settings.rs and remove settings/ folder#123
StudentWeis merged 1 commit into
mainfrom
refactor/flatten-config-settings

Conversation

@StudentWeis
Copy link
Copy Markdown
Owner

Summary

Flatten the config/settings/ subdirectory by inlining the ~30-line validate.rs into settings.rs. No behavior change — purely structural cleanup.

Linked Issue

Closes #122

Changes

  • Moved validation methods (validate_hotkey, validate_window_opacity, validate_storage) from src/config/settings/validate.rs into src/config/settings.rs
  • Removed mod validate; declaration and the settings/ directory
  • Added str::FromStr to the existing std import (was previously brought in by the submodule)
  • Removed redundant use std::str::FromStr in the test module

Testing

  • scripts/precheck.sh passes locally
  • All 434 tests pass, including 38 settings-specific tests

Self-Check

  • PR title follows Conventional Commits
  • No hardcoded user-facing strings — i18n keys added to all locale files
  • Errors defined with thiserror (no manual impl Display/Error)
  • No unrelated changes mixed in

@StudentWeis StudentWeis merged commit dc8c568 into main May 11, 2026
8 checks passed
@StudentWeis StudentWeis deleted the refactor/flatten-config-settings branch May 11, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: flatten config/settings module by inlining validate.rs

1 participant