Skip to content

refactor(gui): hoist background color onto shared base builder#131

Merged
StudentWeis merged 1 commit into
mainfrom
refactor/deduplicate-board-bg
May 12, 2026
Merged

refactor(gui): hoist background color onto shared base builder#131
StudentWeis merged 1 commit into
mainfrom
refactor/deduplicate-board-bg

Conversation

@StudentWeis
Copy link
Copy Markdown
Owner

Summary

Deduplicate the repeated .bg(self.main_panel_surface(...)) call by computing surface_bg once and applying it on the shared base builder.

Linked Issue

Closes #130

Changes

  • Compute surface_bg at the top of Render::render and chain .bg(surface_bg) onto base.
  • Remove 4 redundant per-arm .bg(...) calls (Settings, About, Help, ClipboardList) and the deactivated-state duplicate.

Testing

  • scripts/precheck.sh passes locally
  • New / updated tests cover the change — N/A (purely mechanical, existing tests pass)

Self-Check

  • PR title follows Conventional Commits
  • No hardcoded user-facing strings — i18n keys added to all locale files
  • Errors defined with thiserror (no manual impl Display/Error)
  • No unrelated changes mixed in

@StudentWeis StudentWeis merged commit 5b56430 into main May 12, 2026
8 checks passed
@StudentWeis StudentWeis deleted the refactor/deduplicate-board-bg branch May 12, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: deduplicate background color in board render

1 participant