ci: drop pr-title workflow, bump checkout to v6, slim contribution skill#49
Merged
Merged
Conversation
- Remove .github/workflows/pr-title.yml (Conventional Commit title check no longer enforced via CI). - Bump actions/checkout from v4 to v6 in both jobs of ci.yml. - Slim .agents/skills/ropy-contribution-flow/SKILL.md from 190 to 120 lines by removing duplication with AGENTS.md and the PR template, and tightening prose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Trim CI surface area: drop the dedicated PR-title workflow, bump
actions/checkoutto v6, and slim the contribution skill to remove duplication withAGENTS.md.Linked Issue
N/A — trivial CI / docs change.
Changes
.github/workflows/pr-title.yml: deleted. The Conventional Commit title check is no longer enforced via CI; the rule still lives in the contribution skill and the PR template..github/workflows/ci.yml:actions/checkout@v4→@v6in both theprecheckandcross-buildjobs..agents/skills/ropy-contribution-flow/SKILL.md: 190 → 120 lines. Removed sections that re-statedAGENTS.md(TDD /thiserror/gpui-component/ i18n), the PR template's self-check, the anti-patterns reverse-restatement, and the trailing copy-paste cheatsheet. Conventional Commits rules collected into a single section. Required-checks list updated to reflect the deletedpr-titleworkflow.Testing
scripts/precheck.shpasses locally (414 tests, clippy clean, i18n / icons / themes OK).