refactor: replace per-function expect_used allow with module-level cfg_attr#51
Merged
Merged
Conversation
…g_attr Remove 117 scattered #[allow(clippy::expect_used)] per-function attributes from 9 test-heavy files and replace each with a single module-level: #![cfg_attr(test, allow(clippy::expect_used, clippy::unwrap_used))] This is DRY — one declaration per file instead of repeating on every fn. Refs #50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace 117 scattered per-function
#[allow(clippy::expect_used)]attributes across 9 test-heavy files with a single module-level#![cfg_attr(test, allow(clippy::expect_used, clippy::unwrap_used))]at the top of each file.Linked Issue
Closes #50
Changes
src/repository/cleanup.rs— removed 7 per-function allows, added module-level attrsrc/repository/repo.rs— removed 54 per-function allows, added module-level attrsrc/repository/time_index.rs— removed 33 per-function allows, added module-level attrsrc/repository/favorites.rs— removed 7 per-function allows, added module-level attrsrc/repository/test_helpers.rs— removed 4 per-function allows, added module-level attrsrc/config/settings.rs— removed 5 per-function allows, added module-level attrsrc/clipboard/utils.rs— removed 4 per-function allows, added module-level attrsrc/app.rs— removed 2 per-function allows, added module-level attrsrc/config/autostart.rs— removed 1 per-function allow, added module-level attrTesting
scripts/precheck.shpasses locally