refactor(gui): consolidate assets/icon into assets/icons#63
Merged
Conversation
Move all 14 SVGs from assets/icon/ into assets/icons/ and update the 18 references across 5 source files under src/gui/ so every icon path uses the same icons/ prefix. Delete the now-empty assets/icon/ directory. No behavioral change; scripts/precheck.sh passes. Refs #62
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidate the two sibling icon directories into a single
assets/icons/so all SVGs share one home and one path prefix. Pure path cleanup, no behavioral change.Linked Issue
Closes #62
Changes
assets/icon/intoassets/icons/(now 17 SVGs in total, including the 3 existing gpui-component notification icons)..path("icon/…")references insrc/gui/board/{header,search,records_list}.rsandsrc/gui/panel/{about,settings}.rsto use theicons/prefix.assets/icon/directory.Testing
scripts/precheck.shpasses locally (cargo fmt,cargo clippy,cargo test— 411 passed,check_icons.py: 18 in assets / 18 referenced / 3 allowlisted,check_i18n.py,check_themes.pyall OK)scripts/check/check_icons.py.