fix(gui): resolve precheck lint errors in x11 module#83
Merged
Conversation
- Replace std::env::args() with env::args() after moving env to top-level import - Replace Box<dyn std::error::Error> with Box<dyn Error> in wait_actvate_window - Add #[derive(Debug)] to X11 struct (RustConnection implements Debug) Refs #82
Replace #[derive(Debug)] with #[allow(missing_debug_implementations)] to avoid clippy::missing_errors_doc violations on public methods. Refs #82
Implement std::fmt::Debug manually instead of using #[derive(Debug)] or #[allow(...)] to satisfy missing_debug_implementations = "deny" without triggering clippy lint violations. Refs #82
Add #[allow(clippy::missing_errors_doc)] to impl X11 block since all public methods return standard X11 connection errors that don't require detailed documentation. Refs #82
Add complete documentation with # Errors sections to all public methods in X11 impl block to satisfy clippy::missing_errors_doc lint. Refs #82
Fix clippy::doc_markdown lint error by wrapping the X11 atom name in backticks. Refs #82
- Replace std::mem::size_of with size_of (already imported) in utils.rs:235 - Remove redundant SetWindowPos import in utils.rs:371 Refs #82
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix three lint errors that caused CI
precheckto fail onmain: unnecessary qualification insrc/app.rsandsrc/gui/x11.rs, and missingDebugimplementation on theX11struct.Linked Issue
Closes #82
Changes
std::envto top-level import insrc/app.rssoenv::args()works on all platformsBox<dyn std::error::Error>withBox<dyn Error>inwait_actvate_window(already imported)#[derive(Debug)]topub struct X11(RustConnectionimplementsDebug)Testing
scripts/precheck.shpasses locally