fix(gui): improve about panel text contrast under transparent dark themes#91
Merged
Merged
Conversation
…emes Switch the About panel description text and the muted-state update status text from theme.muted_foreground to theme.foreground so they remain legible when the window is in transparent mode under dark themes, where the muted gray was blending into the translucent background. Refs #90
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve text contrast on the About panel under transparent dark themes by switching the description and muted-state update status text from
theme.muted_foregroundtotheme.foreground.Linked Issue
Closes #90
Changes
src/gui/panel/about.rs: description text now usescx.theme().foreground.src/gui/panel/about.rs: update status text usescx.theme().foregroundfor all non-error states (Idle / Checking / UpToDate / Downloading / Available / ReadyToRestart);Errorkeeps its red color.Testing
scripts/precheck.shpasses locally (clippy clean, 421 tests passed, i18n / icons / themes checks all OK)