Merged
Conversation
Closed
Stypox
commented
Mar 5, 2022
app/src/main/java/org/dicio/dicio_android/skills/timer/TimerInfo.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code is still crappy and definitely needs polishing, but it works as a proof of concept. The timer skill allows to set, cancel and query timers with voice. Timers have a duration and a name (if the user specifies one). At the moment timers are handled in a supposedly bad way since they are in a static field of the
TimerOutputclass, but they would need to be handled by a foreground service, so that if the app is killed the timers are not forgotten about forever. Here is an apk if you want to test it out: app-debug.zipCloses #42