Fix wrong dependencies in net46 nugets#672
Merged
ademar merged 1 commit intoSuaveIO:masterfrom Dec 23, 2017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
this PR should fix wrong dependencies for generated Net4.6 nugets: #656
This seems to be an Albacore issue - Albacore "accumulates" dependencies for projects passed to
nugets_packtask, so quick fix is to make separate task for each "fsproj".There is also an issue with building nuget for
Suave.Testing.fsprojin "Release" mode - also fixed. Now build generates PDB for this project - same as forSuave.fsproj.tools/paket_pack.rb- not sure this is used anywhere in Rakefile.