Allow for scroll to html elements from outside HTML widget #667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tneotia
suggested changes
May 12, 2021
Contributor
Author
|
This package does not have an analysis option, and I think it's using the default dart fmt which is different. Hopefully its not an issue, but if it is let me know what it should be configured so I can update it. |
Contributor
|
Formatting looks fine to me. Nice work! |
Contributor
Author
|
@tneotia what is the next steps for this? |
erickok
approved these changes
May 19, 2021
Contributor
|
@leoafarias it's approved so just waiting for merge, should happen sometime soon :) |
|
@leoafarias @tneotia I am trying to get this feature to work, but no candy. I have a full example, could you help pls? :) #1082 |
Contributor
Author
Seems the issue is closed, but lets take the conversation there if needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently interacting with the HTML widget from outside of it is very difficult. Creating outside links is not possible because anchorKey cannot be set from outside and also class is not exported.
This change allows for a scroll to a certain element to happen from outside the HTML widget.