Skip to content

Allow for scroll to html elements from outside HTML widget #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 19, 2021
Merged

Allow for scroll to html elements from outside HTML widget #667

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35ae6ac
Override and export key
leoafarias May 12, 2021
961391a
Merge branch 'master' of https://github.com/leoafarias/flutter_html
leoafarias May 12, 2021
c6cacad
Renamed anchorKey
leoafarias May 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 37 additions & 22 deletions lib/flutter_html.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,38 @@
library flutter_html;

//export image render api
export 'package:flutter_html/image_render.dart';
//export style api
export 'package:flutter_html/style.dart';
//export render context api
export 'package:flutter_html/html_parser.dart';
//export src for advanced custom render uses (e.g. casting context.tree)
export 'package:flutter_html/src/layout_element.dart';
export 'package:flutter_html/src/replaced_element.dart';
export 'package:flutter_html/src/styled_element.dart';
export 'package:flutter_html/src/interactable_element.dart';

import 'package:flutter/material.dart';
import 'package:flutter/rendering.dart';
import 'package:flutter_html/html_parser.dart';
import 'package:flutter_html/image_render.dart';
import 'package:flutter_html/src/html_elements.dart';
import 'package:flutter_html/style.dart';
import 'package:webview_flutter/webview_flutter.dart';
import 'package:html/dom.dart' as dom;
import 'package:webview_flutter/webview_flutter.dart';

//export render context api
export 'package:flutter_html/html_parser.dart';
//export render context api
export 'package:flutter_html/html_parser.dart';
//export image render api
export 'package:flutter_html/image_render.dart';
//export image render api
export 'package:flutter_html/image_render.dart';
export 'package:flutter_html/src/anchor.dart';
export 'package:flutter_html/src/anchor.dart';
export 'package:flutter_html/src/interactable_element.dart';
export 'package:flutter_html/src/interactable_element.dart';
//export src for advanced custom render uses (e.g. casting context.tree)
export 'package:flutter_html/src/layout_element.dart';
//export src for advanced custom render uses (e.g. casting context.tree)
export 'package:flutter_html/src/layout_element.dart';
export 'package:flutter_html/src/replaced_element.dart';
export 'package:flutter_html/src/replaced_element.dart';
export 'package:flutter_html/src/styled_element.dart';
export 'package:flutter_html/src/styled_element.dart';
//export style api
export 'package:flutter_html/style.dart';
//export style api
export 'package:flutter_html/style.dart';

class Html extends StatelessWidget {
/// The `Html` widget takes HTML as input and displays a RichText
Expand Down Expand Up @@ -49,6 +62,7 @@ class Html extends StatelessWidget {
/// See [its wiki page](https://github.com/Sub6Resources/flutter_html/wiki/Style) for more info.
Html({
Key? key,
GlobalKey? anchorKey,
required this.data,
this.onLinkTap,
this.customRender = const {},
Expand All @@ -61,13 +75,14 @@ class Html extends StatelessWidget {
this.tagsList = const [],
this.style = const {},
this.navigationDelegateForIframe,
}) : document = null,
assert (data != null),
anchorKey = GlobalKey(),
}) : document = null,
assert(data != null),
_anchorKey = anchorKey ?? GlobalKey(),
super(key: key);

Html.fromDom({
Key? key,
GlobalKey? anchorKey,
@required this.document,
this.onLinkTap,
this.customRender = const {},
Expand All @@ -80,13 +95,13 @@ class Html extends StatelessWidget {
this.tagsList = const [],
this.style = const {},
this.navigationDelegateForIframe,
}) : data = null,
}) : data = null,
assert(document != null),
anchorKey = GlobalKey(),
_anchorKey = anchorKey ?? GlobalKey(),
super(key: key);

/// A unique key for this Html widget to ensure uniqueness of anchors
final Key anchorKey;
final GlobalKey _anchorKey;

/// The HTML data passed to the widget as a String
final String? data;
Expand All @@ -111,7 +126,6 @@ class Html extends StatelessWidget {
/// You can return a widget here to override the default error widget.
final OnMathError? onMathError;


/// A parameter that should be set when the HTML widget is expected to be
/// flexible
final bool shrinkWrap;
Expand Down Expand Up @@ -143,13 +157,14 @@ class Html extends StatelessWidget {

@override
Widget build(BuildContext context) {
final dom.Document doc = data != null ? HtmlParser.parseHTML(data!) : document!;
final dom.Document doc =
data != null ? HtmlParser.parseHTML(data!) : document!;
final double? width = shrinkWrap ? null : MediaQuery.of(context).size.width;

return Container(
width: width,
child: HtmlParser(
key: anchorKey,
key: _anchorKey,
htmlData: doc,
onLinkTap: onLinkTap,
onImageTap: onImageTap,
Expand Down