changes needed to get building in 2025 (minus changes to singleaxis) …#17
Merged
changes needed to get building in 2025 (minus changes to singleaxis) …#17
Conversation
…15) Co-authored-by: Nobody5050 <levibelland@gmail.com>
nobody5050
reviewed
Jan 17, 2025
Member
nobody5050
left a comment
nobody5050
left a comment
There was a problem hiding this comment.
Make sure you delete AutoFactory.cpp or you'll get linking errors otherwise LGTM 🚀
nobody5050
approved these changes
Jan 17, 2025
habig
reviewed
Jan 19, 2025
Contributor
habig
left a comment
habig
left a comment
There was a problem hiding this comment.
The changes seem to make sense.
One thing I'd generally like to do when reviewing is to build the changes to see for myself that things work, rather than trusting my eyeballs.
BUT - how does one build the common library? It's not the usual robot code of course. I don't see makefiles, but VScode isn't my normal tool so I'm missing something obvious here. Can someone point me at the docs for building this? Thanks!
habig
approved these changes
Jan 20, 2025
Contributor
habig
left a comment
habig
left a comment
There was a problem hiding this comment.
Approving since testing needs to take place at runtime.
nobody5050
added a commit
to nobody5050/SubZero-common
that referenced
this pull request
Feb 13, 2025
SubZero-Robotics#17) * changes needed to get building in 2025 (minus changes to singleaxis) (SubZero-Robotics#15) Co-authored-by: Nobody5050 <levibelland@gmail.com> * Fix code style issues with clang_format --------- Co-authored-by: Nobody5050 <levibelland@gmail.com> Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…(#15)
Description of pull request
This PR
Implements new updates for PhotonVision and updates AutoFactory.
Before you merge