ISingleAxisSubsystem fixes
#22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobody5050
reviewed
Feb 3, 2025
nobody5050
reviewed
Feb 3, 2025
nobody5050
requested changes
Feb 3, 2025
Member
nobody5050
left a comment
nobody5050
left a comment
There was a problem hiding this comment.
Looks good, solve the TODO commentd before merging
CanyonJ
approved these changes
Feb 3, 2025
nobody5050
approved these changes
Feb 3, 2025
nobody5050
pushed a commit
to nobody5050/SubZero-common
that referenced
this pull request
Feb 13, 2025
* Try to get rev 2025 fixing (doesn't build) * Comment out errors; code builds doesn't work * Use rev pid config (builds) * Fix `SetEncoderConversionFactor()` and `SetAbsoluteEncoderConversionFactor()` * Fix code style issues with clang_format * Remove autofactory method implementations in header file * Add template type for pid config in `PidMotorControllerTuner` * Fix code style issues with clang_format * Remove solved TODOs * Remove `TODO` in PID * Add default behavior to pit settings object * Fix code style issues with clang_format --------- Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of pull request
This PR fixed ISingleAxisSubsystem using the new rev API
Closes #18
Closes #19