Skip to content

Fix hearthis variant mapping in Player Checker toolkit#196

Merged
Subfader merged 1 commit intomainfrom
codex/fix-hearthis-variant-mapping-issue
Mar 2, 2026
Merged

Fix hearthis variant mapping in Player Checker toolkit#196
Subfader merged 1 commit intomainfrom
codex/fix-hearthis-variant-mapping-issue

Conversation

@Subfader
Copy link
Copy Markdown
Owner

@Subfader Subfader commented Mar 2, 2026

Motivation

  • Hearthis URL variants were being emitted as separate list items (one per variant) instead of mapping short/long variants into a single line, causing duplicated and empty entries in the Player Checker toolkit output.

Description

  • Preserve each item’s original variant role by recording the original variant type into a new data-variantorigin attribute on the processed link and its parent list item in includes/toolkit.js.
  • Use the data-variantorigin metadata to only remove the mirrored not-preferred duplicate when a preferred origin item exists, keeping the preferred-origin list item intact and restoring the single-line short = long mapping behavior.
  • Bumped the Player Checker userscript version and updated the @require cache-buster for includes/toolkit.js in Player_Checker/script.user.js.

Testing

  • Ran node --check includes/toolkit.js which completed successfully.
  • Ran node --check Player_Checker/script.user.js which completed successfully.

Codex Task

@Subfader Subfader merged commit 9c6720b into main Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant