Parsing json result fails if eslint outputs warnings

[vegar]

I posted first an issue in SublimeLinter, but it looks like an inprovement of SublimeLinter-eslint is whats needed.

Basically, eslint outputs some deprecation messages alongside the lint errors, which again breaks the parsing of the output.

[2018-03-06 16:16:42,979 - INFO     - SublimeLinter.lint.linter] eslint: cwd: C:\Source\flis
SublimeLinter: #15 SublimeLinter.sublime-package:809: eslint output:
    [{"filePath":"C:\\Source\\flis\\WebApiRole\\src\\app\\components\\button\\dropdown-button.component.js","messages":[{"ruleId":"quotes","severity":2,"message":"Strings must use singlequote.","line":16,"column":17,"nodeType":"Literal","source":"      restrict: \"EA\",","endLine":16,"endColumn":21,"fix":{"range":[260,264],"text":"'EA'"}},{"ruleId":"no-multi-spaces","severity":2,"message":"Multiple spaces found before '}'.","line":24,"column":13,"nodeType":"Punctuator","source":"      }     })","fix":{"range":[482,487],"text":" "}},{"ruleId":"object-curly-newline","severity":2,"message":"Expected a line break before this closing brace.","line":24,"column":13,"nodeType":"ObjectExpression","source":"      }     })","fix":{"range":[487,487],"text":"\n"}}],"errorCount":3,"warningCount":0,"fixableErrorCount":3,"fixableWarningCount":0,"source":"(function() {\n  'use strict';\n\n  DropdownButtonComponentCtrl.$inject = [];\n\n  function DropdownButtonComponentCtrl() {\n    var vm = this;\n\n    vm.$onInit = function() {\n\n    };\n  }\n\n  angular.module('finale')\n    .component('dropdownButton', {\n      restrict: \"EA\",\n\n      templateUrl: 'src/app/components/button/dropdown-button.component.html',\n      controller: 'DropdownButtonComponentCtrl',\n      transclude: true,\n      bindings: {\n        icon: '@',\n        items: '<'\n      }     })\n    .controller('DropdownButtonComponentCtrl', DropdownButtonComponentCtrl);\n}());\n"}]
    The rule `angular/service-name` will be split up to different rules in the next version. Please read the docs for more information

Suggested solution is to break output on line feeds, parse first as json and treat the rest as warnings for the console.,

[kaste]

Can you please edit the description so it shows up formatted as code.

[kaste]

I already hate this fix before I wrote it. LOL.

Can we just suppress these warnings via a command line switch? Bc we don't need them anyway.

[braver]

@kaste Good idea.

Handling warnings:
  --quiet                        Report errors only - default: false
  --max-warnings Int             Number of warnings to trigger nonzero exit code - default: -1

--quiet seems like it might do it

[kaste]

No, that refers to lint warnings. (Dunno why they have this switch.)

[braver]

Oh, that's stupid. I don't see anything else that's useful in their docs. Perhaps the warnings are in a different error stream? What happens if we use STREAM_STDOUT instead of both? (I don't know how to reproduce the situation really)

[FichteFoll]

The issue in OP can probably be triggered by using the eslint angular plugin and specifying this: https://github.com/Gillespie59/eslint-plugin-angular/blob/master/docs/rules/service-name.md

Looking at stdout separately sounds like a good idea.

Btw, I don't think any of the warning-related options (which are indeed for lint warnings, not for warnings about the configuration) are bad.

[vegar]

Found this thread: eslint/eslint#3039

I'm tempted to reopen it. Having all deprecated rules set to disabled as a solution seems a little short sighted. I would like mye linting rules as is even though they will change in a future release...

[kaste]

Grr, FWIW if I use the 'rule' 'no-spacsed-func' I get

'messages': [{'column': 1,
                'line': 1,
                'message': "Definition for rule 'no-spacsed-func' was not found",
                'nodeType': None,
                'ruleId': 'no-spacsed-func',
                'severity': 2,

t.i. just normal json back.

[kaste]

And if use and violate the clearly deprecated 'no-spaced-func' I get

[{'errorCount': 1,
  'filePath': 'D:\\maik.h\\src\\node-updater.js',
  'fixableErrorCount': 1,
  'fixableWarningCount': 0,
  'messages': [{'column': 1,
                'fix': {'range': [453, 454], 'text': ''},
                'line': 20,
                'message': 'Unexpected space between function name and paren.',
                'nodeType': 'CallExpression',
                'ruleId': 'no-spaced-func',
                'severity': 2,
                'source': 'Hello ()'}],

No deprecation warning.

[kaste]

I just looking for something simple to reproduce, then fix it, dammit!

[vegar]

The deprecation warning I get is for the before mentioned angular service-name rule.

[kaste]

Oh, these suckers, they just use console.warn https://github.com/Gillespie59/eslint-plugin-angular/blob/9d64ca19128ecba3c3025efd89c60a0568ec5d86/rules/service-name.js#L70-L74

whereby eslint has an API for that https://github.com/eslint/eslint/blob/66a1e9aa85c37c1d4430ad633d8354930c818796/lib/rules/no-spaced-func.js#L13-L27

[vegar]

So this is actually an eslint-plugin-angular-issue?