Skip to content

Fix: 'column' is optional #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2018
Merged

Fix: 'column' is optional #222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions linter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,15 @@ def find_errors(self, output):
if match['message'].startswith('File ignored'):
continue

column = match.get('column', None)
if column is not None:
# apply line_col_base manually
column = column - 1

yield (
match,
match['line'] - 1, # apply line_col_base manually
match['column'] - 1,
column,
match['ruleId'] if match['severity'] == 2 else '',
match['ruleId'] if match['severity'] == 1 else '',
match['message'],
Expand All @@ -76,9 +81,12 @@ def find_errors(self, output):

def reposition_match(self, line, col, m, vv):
match = m.match
if match.get('fatal', False): # parse error
if (
col is None or
match.get('fatal', False) # parse error
):
text = vv.select_line(line)
return line, 0, len(text) # select whole line?
return line, 0, len(text) # select whole line
return super().reposition_match(line, col, m, vv)

# apply line_col_base manually
Expand Down